feat(core): New flexible states#291
Merged
sanguinariojoe merged 16 commits intoFloatingArrayDesign:devfrom Mar 18, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
#290
#261
The new flexible states are here! With these new states it is rather easy to install new variables, which can have fixed lengths (real, vec, vec6...) or variable lengths depending on the instance (e.g. lines as vec3 and rods as a combination of vec7 and vec6).
It is fairly optimized, avoiding some copies here and there. However, the implementation comes to a performance cost, becoming as twice slower as the previous implementation. I suppose some other optimizations can be made to avoid some copies. I just do not know if it is worth the effort, as long as we are bringing --hopefully soon-- a time scheme which will make simulations waaaaaay faster.